25 Jul 2012 16:18
64 Bit Fixes: Passing correct type to getIndexes:maxLength:inIndexRange: [...]
| Commit from mjohnston | 2012-07-25 16:18 CEST |
| Adun | Kernel/AdunKernel/Framework/AdFrameworkFunctions.m | 1.83 | >>> | 1.84 | |
| Adun | Kernel/AdunKernel/Framework/AdIndexSetConversions.m | 1.11 | >>> | 1.12 | |
| Adun | Kernel/AdunKernel/Framework/AdunCellListHandler.m | 1.42 | >>> | 1.43 | |
| Adun | Kernel/AdunKernel/Framework/AdunDataMatrix.m | 1.61 | >>> | 1.62 | |
| Adun | Kernel/AdunKernel/Framework/AdunElementSelection.m | 1.8 | >>> | 1.9 | |
| Adun | Kernel/AdunKernel/Framework/AdunSimpleListHandler.m | 1.10 | >>> | 1.11 | |
| Adun | Kernel/AdunKernel/Framework/AdunSmoothedGBTerm.m | 1.65 | >>> | 1.66 |
<div>
<table width="100%" class="csetheader"><tr>
<td align="left">Commit from mjohnston</td>
<td align="right">2012-07-25 16:18 CEST</td>
</tr></table>64 Bit Fixes: Passing correct type to getIndexes:maxLength:inIndexRange:
Passing buffer of incorrect size to this method was main cause of problems on 64 bit.
Basically the code was passing int arrays instead of NSUInteger arrays which are twice the size in 64bit (they are the same size in 32bit which is why it works there)
Hence seg-faults were occuring as the int arrays were overflowed.
<table cellspacing="0" cellpadding="3" class="history">
<tr class="history">
Module
File name
Revision
</tr>
<tr class="itemM0">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdFrameworkFunctions.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdFrameworkFunctions.m?rev=1.83&content-type=text/vnd.viewcvs-markup">1.83</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdFrameworkFunctions.m?r1=1.83&r2=1.84">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdFrameworkFunctions.m?rev=1.84&content-type=text/vnd.viewcvs-markup">1.84</a></td>
</tr>
<tr class="itemM1">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdIndexSetConversions.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdIndexSetConversions.m?rev=1.11&content-type=text/vnd.viewcvs-markup">1.11</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdIndexSetConversions.m?r1=1.11&r2=1.12">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdIndexSetConversions.m?rev=1.12&content-type=text/vnd.viewcvs-markup">1.12</a></td>
</tr>
<tr class="itemM0">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdunCellListHandler.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunCellListHandler.m?rev=1.42&content-type=text/vnd.viewcvs-markup">1.42</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunCellListHandler.m?r1=1.42&r2=1.43">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunCellListHandler.m?rev=1.43&content-type=text/vnd.viewcvs-markup">1.43</a></td>
</tr>
<tr class="itemM1">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdunDataMatrix.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunDataMatrix.m?rev=1.61&content-type=text/vnd.viewcvs-markup">1.61</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunDataMatrix.m?r1=1.61&r2=1.62">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunDataMatrix.m?rev=1.62&content-type=text/vnd.viewcvs-markup">1.62</a></td>
</tr>
<tr class="itemM0">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdunElementSelection.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunElementSelection.m?rev=1.8&content-type=text/vnd.viewcvs-markup">1.8</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunElementSelection.m?r1=1.8&r2=1.9">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunElementSelection.m?rev=1.9&content-type=text/vnd.viewcvs-markup">1.9</a></td>
</tr>
<tr class="itemM1">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdunSimpleListHandler.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunSimpleListHandler.m?rev=1.10&content-type=text/vnd.viewcvs-markup">1.10</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunSimpleListHandler.m?r1=1.10&r2=1.11">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunSimpleListHandler.m?rev=1.11&content-type=text/vnd.viewcvs-markup">1.11</a></td>
</tr>
<tr class="itemM0">
<td class="itemact"></td>
<td class="item">Adun</td>
<td class="item">Kernel/AdunKernel/Framework/AdunSmoothedGBTerm.m</td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunSmoothedGBTerm.m?rev=1.65&content-type=text/vnd.viewcvs-markup">1.65</a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunSmoothedGBTerm.m?r1=1.65&r2=1.66">>>></a></td>
<td class="itemrev"><a href="http://cvs.gna.org/viewcvs/adun/Adun/Kernel/AdunKernel/Framework/AdunSmoothedGBTerm.m?rev=1.66&content-type=text/vnd.viewcvs-markup">1.66</a></td>
</tr>
</table>
<p><br></p>
<p class="footer">Generated by <a href="http://home.gna.org/cvsreport/">cvsreport 0.3.5-cvs</a></p>
</div>
RSS Feed